Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal/2022.3/staging #8019

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Internal/2022.3/staging #8019

merged 3 commits into from
Jan 11, 2024

Conversation

UnityAljosha
Copy link
Collaborator

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

Adrian1066 and others added 3 commits January 3, 2024 12:13
@Adrian1066
[content automatically redacted] touching PlatformDependent folder
f990727
@kecho
[Backport 2022.3][Jira # UUM-57601] Read / Write hack fix for async c…
a18e49f 
…ompute issues on HDRP console

Async compute Presents issues when depending on the first texture read of depth. In some platforms (vulkan/dx12 and some consoles) the first read of depth is actually a write because of decompression / layout / barriers.
Async compute is inserting the fence before this operation because RenderGraph sees everything as a simple Read / Write.
Temporarily hacking this so the first read of depth is tagged as a write, so the correct fence is inserted.
@theopnv
[22.3] Bump SRP packages to 14.0.10
149d8c6 
Bump SRP packages to 14.0.10
@UnityAljosha UnityAljosha requested review from a team as code owners January 11, 2024 07:52
@UnityAljosha UnityAljosha merged commit 1ecb43d into 2022.3/staging Jan 11, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UnityAljosha @Adrian1066 @kecho @theopnv