Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/2023.2/staging #8018

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Conversation

UnityAljosha
Copy link
Collaborator

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

Adrian1066 and others added 9 commits January 3, 2024 23:20
Bump SRP packages to 16.0.5
… in templates

Fix UUM-47093. Opening a brand new URP template shouldn't prompt for material upgrades.
Fix volumetric clouds in planar reflections (fix zbuffer to linear depth for oblique projection matrices)
Support negative scale on water surfaces flipping regions and current

Allowed multi editing on water surfaces

Fixed max raymarching step size, which was removed as mistake during atmospheric sky PR (reported here https://forum.unity.com/threads/volumetric-clouds.1078811/page-15)
Without fix:
![image](https://media.github.cds.internal.unity3d.com/user/2154/files/b91edf51-995e-464d-b5a8-e3d5ee8503fc)

With the fix:
![image](https://media.github.cds.internal.unity3d.com/user/2154/files/09c1e98a-f8e0-4198-9d5a-20762cb5e1e4)

Also include fix for #42040 and #42127
Fix https://jira.unity3d.com/browse/UUM-56409.

The method called was not correct, Remove All was not implemented at all so it is now done according to how RemoveComponent works.
This change makes sure that tempRT are scaled correctly with Quest renderViewportScale feature without having to reallocate them. 

Currently, changing XRSettings.renderViewportScale will trigger a reallocation of all tempRT since we modify the cameraTargetDescriptor width/height, which is used by render passes to configure their tempRT. 

The fix avoids changing the value of cameraTargetDescriptor by using the full RT size as the width and height and enabling scaling of all render targets (using the ScalableBufferManager) that use the cameraTargetDescriptor.

Minor doc fixes.
*[See [this document](https://docs.google.com/document/d/1C4Vc7dOKgoZ2mNqMdugHDg-w6iN7iUYdlBQMGDmVS3E/edit) for details on what can land in 2023.3.]*

This PR fixes an issue where a SpriteShapeRenderer with mask interaction set is unable to be masked by a SpriteMask when using a URP pipeline.
@UnityAljosha UnityAljosha requested review from a team as code owners January 11, 2024 07:51
@UnityAljosha UnityAljosha merged commit 799fd42 into 2023.2/staging Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants