Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/2023.2/staging #7981

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Conversation

UnityAljosha
Copy link
Collaborator

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

lewish-unity and others added 8 commits October 16, 2023 14:32
…ckport [2023.2]

Fixes a rendering issue with sprite shape where it was not drawing all of its submeshes.
*[See [this document](https://docs.google.com/document/d/1C4Vc7dOKgoZ2mNqMdugHDg-w6iN7iUYdlBQMGDmVS3E/edit) for details on what can land in 2023.3.]*

This PR fixes an issue when rendering under URP where a TilemapRenderer in Individual mode and SpriteRenderers which are using non-SRP batchable materials but can be dynamic batched are not dynamic batched.
…rred (UUM-47782)

Backport of #37827 and #38190

This PR does three things:
1. Fixes UUM-47782 where a IsFormatSupported check was being used while making builds (#37827)
2. Fixes an issue where Unlit shaders in URP were missing the `_GBUFFER_NORMALS_OCT` keyword. (#37827)
3. Improves the shader variant stripping for that Accurate GBuffer Normals (#38190)
…tter what RP is active

AssetImportWorker is a completely separate process which will have their own instance of Render Pipeline.
Although, it can't ensure and migrate any asset. This operations should be performed on the main process. 
This means they should create Render Pipeline instance only after the main process migrated everything.
We are achieving this by always ensuring Global Settings no matter what Render Pipeline is active.
In addition, we need to save the assets otherwise Workers will not see the changes.
https://jira.unity3d.com/browse/UUM-47264
Disable motion blur in EditMode to keep editing clear.
- Fixes the following issue: [UUM-35569](https://jira.unity3d.com/browse/UUM-35569) The DecalDrawSystem when in Screen Space mode was accessing the wrong decal data structure for world space transforms causing situations where one decal would leave screen but cause another still visible one to be culled erroneously.
@UnityAljosha UnityAljosha requested review from a team as code owners October 24, 2023 07:39
@UnityAljosha UnityAljosha merged commit 46d0027 into 2023.2/staging Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants