Internal/2023.1/staging #7968
Merged
Internal/2023.1/staging #7968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lighted border after click Repo steps: Open unity scene (HDRP) Right click project window > Create > Visual Effects > Visual Effect Graph Create a graph and name is anything Click the Question mark icon on the top left of the viewport The documentation page should open, navigate back to the unity project and notice the button is still selected by indication of the blue light Expected result: No selection left on button Actual result: Blue selection indicator on button Reproducible with: 2022.2.13f1, 2023.1.0b15, 2023.2.0a14 Cannot test with: 2020.3.46f1, 2021.3.21f1 (Due to functionality not existing) Platforms tested: Win 11 
… VFXView Jira: https://jira.unity3d.com/browse/UUM-28528 Steps to reproduce: - Open the VFX "No Asset" window (menu `Window`->`Visual Effects`->`Visual Effect Graph`) - If the blackboard is not opened, open an existing VFX (or create a new one) and open the blackboard, then close and reopen the "No Asset" window. - Click on the [+] button in the blackboard <img width="902" alt="Unity_BOeC0iinDa" src="https://media.github.cds.internal.unity3d.com/user/4003/files/60fd3daf-99c9-499a-a652-ebdface369e5"> => An error is thrown in the console The fix for this issue is to disable the [+] button for the "No Asset" window. <img width="670" alt="Unity_leeT7chM2m" src="https://media.github.cds.internal.unity3d.com/user/4003/files/b9cd40fd-dcb7-4587-ad82-50d3cd5ae8b6"> ### 🎁 Gift improvement Looking at the screenshots above I noticed that the "Create new Visual Effect Graph" button was squashed when the window is too small. So I did a few changes to fix that. See the videos below. **Before**  **After** 
…using different textures or graphic buffers VFX Instancing allows to batch several VisualEffect components together to process their compute shaders with a single dispatch, and to render them together to save CPU time preparing the drawcalls. Previous to this PR, it is possible to batch VisualEffect with different values in exposed properties, as long as those properties are not textures, meshes, or graphic buffers, that require different bindings. When a VisualEffectAsset detected a variable expression with type of one of those objects, instancing was disabled. This PR enables instancing again for those cases, and allows the compute shaders to group instances based on the values of such variable objects in that specific compute shader. This PR does not handle this scenario for drawcalls in an optimal way, so they still have to be rendered one by one as if they were not batched.  For instance, if there is a VisualEffectAsset with an exposed texture that is being used in the Update context, and a few VisualEffect of that type, with some of them overriding the texture, the batch will be processed like this: - Init compute shader will be processed at the same time for all the instances, as it is not using the exposed texture. - Update will be split in several dispatches, one for each different value of the exposed texture. Between each dispatch we only have to upload the instance active indirect and the instance prefix sum (if needed) and to bind the corresponding texture. - OutputUpdate, if present, will also be processed at the same time for all the instances, if it is not using the exposed texture. - Rendering will be batched for all instances, as the exposed texture in this example is not used in rendering.    However, if we have the same exposed texture being used by the Output context: - Init and Update computes will be processed each of them as a single dispatch - OutputUpdate will be split in as many dispatches as different texture values are used by the VisualEffects. - Rendering of instances with the default value will be processed together. VisualEffect instances with an overriden value will be processed ONE BY ONE, regardless of how many of them are using the same texture. This will be addressed in a separate PR.    Apart from those changes, this PR includes some improvements to VFX culling and some fixes.
Bump SRP packages to 15.0.7
This PR is mainly addressing an issue about creating subgraph with incompatible port. This issue has been solved by d83b214482e58ec3f72935e31e8f758ce3c240a8 and additional condition `newTargetParameter.type == linkedParameter.parentController.model.type` The unexpected exception while creating a subgraph was creating a dangling state and corrupted graph leading to a crash in `VFXMemorySerializerBindings::StoreObjects` (when a dependencies is `null` for whatever reason). I used this opportunity to handle this most obvious failure throwing an exception in C#. It won't solve all issue but prevent unexpectedly exiting Unity in that case. Bonus after discussion, solving UUM-40383 Missing link on activation slot.
Remove unexpected scene tab while clicking on object picker. Probably indirectly introduced by the removal of custom object field https://github.cds.internal.unity3d.com/unity/unity/pull/24016
Fix rendering issue with WebGL on Apple M1/2 processors (Macbook, iPhone) when URP Depth Priming is enabled. Because Depth Priming is questionable on WebGL, due to that WebGL builds can run on both desktop and mobile, it seems reasonable to just disable depth priming all together for WebGL.
Fix unexpected missing refraction property in some case of VFX. Issue introduced at https://github.cds.internal.unity3d.com/unity/unity/commit/7986ee8ea4efd9647658ebfd201837e76f6716ef As commented in code, this special additional check is only needed because VFX is taking a shortcut.
Fixes missing shadergraph include on HDRP see https://jira.unity3d.com/browse/UUM-51851
… shown when Developer Mode is enabled. Backport of https://github.cds.internal.unity3d.com/unity/unity/pull/36468
gathering of PRs Improve computation of hashCode for animationCurves (#35356) Add warning message in light cluster override UI if raytraycing is off (#35343) Fixed an issue where non directional light could react to "interact with sky" flag. (#35349) [HDRP] HDRP Wizard Warning Non-Built-In Materials (#35263) ensure camera are valid before destroying (#35491) Fix the SetData error by adding a max light count + by fixing the Assert (wasn't working) (#35305) fix refcounting and cleanup of skyContext when renderer changes (#35437) [HDRP] Fixed cascaded shadowmaps cascade borders and blending issue with shadow mask (#35432)
This PR fixes transparent materials never disappearing from the "Save Assets" window popup even after clicking "Save All" Details: *The keyword state for `_ALPHAPREMULTIPLY_ON` was being disabled and then enabled again, this was causing the material to get marked as dirty *For this reason now we make sure to only call `SetKeyword` once at the end instead of calling `DisableKeyword` and `EnableKeyword` for transparent materials (the material should not get marked as dirty if the state doesn't changed from what it was set to before)
This PR simply adds one line about the projection axis of the decals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.