Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TS to Ts prefix #249

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Rename TS to Ts prefix #249

merged 1 commit into from
Feb 13, 2025

Conversation

CaelmBleidd
Copy link
Member

No description provided.

): UExpr<out USort> {
return mkEq(lhs, rhs)
}

override fun TSContext.resolveFakeObject(
override fun TsContext.resolveFakeObject(

Check warning

Code scanning / detekt

One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand. Warning

The function resolveFakeObject is too long (161). The maximum length is 100.
@@ -99,7 +99,7 @@
)
}

protected inline fun <reified T1 : TSObject, reified T2 : TSObject, reified T3 : TSObject, reified R : TSObject> discoverProperties(
protected inline fun <reified T1 : TsObject, reified T2 : TsObject, reified T3 : TsObject, reified R : TsObject> discoverProperties(

Check warning

Code scanning / detekt

Reports lines with exceeded length Warning test

Exceeded max line length (120)
@@ -99,7 +99,7 @@
)
}

protected inline fun <reified T1 : TSObject, reified T2 : TSObject, reified T3 : TSObject, reified R : TSObject> discoverProperties(
protected inline fun <reified T1 : TsObject, reified T2 : TsObject, reified T3 : TsObject, reified R : TsObject> discoverProperties(

Check warning

Code scanning / detekt

Line detected, which is longer than the defined maximum line length in the code style. Warning test

Line detected, which is longer than the defined maximum line length in the code style.
@@ -122,7 +122,7 @@
)
}

protected inline fun <reified T1 : TSObject, reified T2 : TSObject, reified T3 : TSObject, reified T4 : TSObject, reified R : TSObject> discoverProperties(
protected inline fun <reified T1 : TsObject, reified T2 : TsObject, reified T3 : TsObject, reified T4 : TsObject, reified R : TsObject> discoverProperties(

Check warning

Code scanning / detekt

Reports lines with exceeded length Warning test

Exceeded max line length (120)
@@ -122,7 +122,7 @@
)
}

protected inline fun <reified T1 : TSObject, reified T2 : TSObject, reified T3 : TSObject, reified T4 : TSObject, reified R : TSObject> discoverProperties(
protected inline fun <reified T1 : TsObject, reified T2 : TsObject, reified T3 : TsObject, reified T4 : TsObject, reified R : TsObject> discoverProperties(

Check warning

Code scanning / detekt

Line detected, which is longer than the defined maximum line length in the code style. Warning test

Line detected, which is longer than the defined maximum line length in the code style.
import org.usvm.memory.URegisterStackLValue
import org.usvm.model.UModelBase
import org.usvm.types.first
import org.usvm.types.single

class TSTestResolver(
private val state: TSState,
class TsTestResolver(

Check warning

Code scanning / detekt

If a source file contains only a single non-private top-level class or object, the file name should reflect the case-sensitive name plus the .kt extension. Warning test

The file name 'TSTestResolver' does not match the name of the single top-level declaration 'TsTestResolver'.
}

private fun resolvePrimitive(
expr: UExpr<out USort>,
type: EtsPrimitiveType,
): TSObject = when (type) {
): TsObject = when (type) {

Check warning

Code scanning / detekt

Braces do not comply with the specified policy Warning test

Inconsistent braces, make sure all branches either have or don't have braces.
return isTruthy(x.number)
}

fun isTruthy(x: TSObject.TSClass): Boolean {
fun isTruthy(x: TsObject.TsClass): Boolean {

Check warning

Code scanning / detekt

A function that only returns a constant is misleading. Consider declaring a constant instead. Warning test

isTruthy is returning a constant. Prefer declaring a constant instead.
return isTruthy(x.number)
}

fun isTruthy(x: TSObject.TSClass): Boolean {
fun isTruthy(x: TsObject.TsClass): Boolean {

Check warning

Code scanning / detekt

Function parameter is unused and should be removed. Warning test

Function parameter x is unused.
@CaelmBleidd CaelmBleidd requested a review from Lipen February 13, 2025 07:28
Copy link
Member

@Lipen Lipen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏God bless these changes🙏

@CaelmBleidd CaelmBleidd merged commit 57856b7 into main Feb 13, 2025
6 checks passed
@CaelmBleidd CaelmBleidd deleted the caelmbleidd/renaming branch February 13, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants