Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EtsCfgToDot #307

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix EtsCfgToDot #307

merged 1 commit into from
Feb 14, 2025

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Feb 13, 2025

This PR fixes EtsCfg.toDot method: (1) escape " in labels, (2) showing value-less returns simply as "return" instead of "return null".

@Lipen Lipen requested a review from CaelmBleidd February 13, 2025 15:06
Copy link
Contributor

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 26s ⏱️ -1s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit feed79d. ± Comparison against base commit 6db1ff5.

Copy link
Contributor

Test results on JDK 19

 72 files  ±0   72 suites  ±0   4m 42s ⏱️ +3s
628 tests ±0  618 ✅ ±0  10 💤 ±0  0 ❌ ±0 
698 runs  ±0  688 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit feed79d. ± Comparison against base commit 6db1ff5.

Copy link
Contributor

Test results on JDK 8

 72 files  ±0   72 suites  ±0   4m 53s ⏱️ +7s
628 tests ±0  615 ✅ ±0  13 💤 ±0  0 ❌ ±0 
698 runs  ±0  685 ✅ ±0  13 💤 ±0  0 ❌ ±0 

Results for commit feed79d. ± Comparison against base commit 6db1ff5.

Copy link
Contributor

Test results on JDK 11

 72 files  ±0   72 suites  ±0   5m 17s ⏱️ +5s
628 tests ±0  620 ✅ ±0  8 💤 ±0  0 ❌ ±0 
698 runs  ±0  690 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit feed79d. ± Comparison against base commit 6db1ff5.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.19%. Comparing base (6db1ff5) to head (feed79d).
Report is 3 commits behind head on neo.

Files with missing lines Patch % Lines
...rc/main/kotlin/org/jacodb/ets/utils/EtsCfgToDot.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #307      +/-   ##
============================================
- Coverage     69.19%   69.19%   -0.01%     
  Complexity     2474     2474              
============================================
  Files           269      269              
  Lines         15441    15442       +1     
  Branches       2281     2281              
============================================
  Hits          10685    10685              
  Misses         3829     3829              
- Partials        927      928       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lipen Lipen merged commit b70957d into neo Feb 14, 2025
12 checks passed
@Lipen Lipen deleted the lipen/fix-ets-cfg-to-dot branch February 14, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants