Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute SHA in a separate job step #302

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Compute SHA in a separate job step #302

merged 1 commit into from
Feb 5, 2025

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Feb 5, 2025

This PR improves GHA workflow for triggering JitPack build by extracting the computation of short (of length 10) SHA into a separate job step. This allows for observing the actual 10-digit sha in CI logs.

@Lipen Lipen requested a review from Saloed February 5, 2025 15:01
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 26s ⏱️ -3s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 769f735. ± Comparison against base commit d03090c.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test results on JDK 8

 71 files  ±0   71 suites  ±0   4m 49s ⏱️ -1s
625 tests ±0  612 ✅ ±0  13 💤 ±0  0 ❌ ±0 
695 runs  ±0  682 ✅ ±0  13 💤 ±0  0 ❌ ±0 

Results for commit 769f735. ± Comparison against base commit d03090c.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test results on JDK 19

 71 files  ±0   71 suites  ±0   4m 43s ⏱️ -3s
625 tests ±0  615 ✅ ±0  10 💤 ±0  0 ❌ ±0 
695 runs  ±0  685 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit 769f735. ± Comparison against base commit d03090c.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.36%. Comparing base (d03090c) to head (769f735).
Report is 1 commits behind head on neo.

Additional details and impacted files
@@            Coverage Diff            @@
##                neo     #302   +/-   ##
=========================================
  Coverage     70.36%   70.36%           
  Complexity     2471     2471           
=========================================
  Files           269      269           
  Lines         15208    15208           
  Branches       2274     2274           
=========================================
  Hits          10701    10701           
  Misses         3577     3577           
  Partials        930      930           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test results on JDK 11

 71 files  ±0   71 suites  ±0   5m 12s ⏱️ +3s
625 tests ±0  617 ✅ ±0  8 💤 ±0  0 ❌ ±0 
695 runs  ±0  687 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 769f735. ± Comparison against base commit d03090c.

@Lipen Lipen merged commit ea4c69a into neo Feb 5, 2025
12 checks passed
@Lipen Lipen deleted the lipen/ci-jitpack-trigger branch February 5, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants