Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EntityCollector #301

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add EntityCollector #301

merged 1 commit into from
Feb 5, 2025

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Feb 3, 2025

This PR adds AbstractHandler and collectTo similar to AbstractFullExprSetCollector from jvm module.

@Lipen Lipen changed the title Add Collector Add EntityCollector Feb 3, 2025
@Lipen Lipen requested a review from Saloed February 3, 2025 16:00
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 27s ⏱️ -2s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 8691e42. ± Comparison against base commit d03090c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test results on JDK 8

 72 files  +1   72 suites  +1   4m 39s ⏱️ -9s
627 tests +2  614 ✅ +2  13 💤 ±0  0 ❌ ±0 
697 runs  +2  684 ✅ +2  13 💤 ±0  0 ❌ ±0 

Results for commit 8691e42. ± Comparison against base commit d03090c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test results on JDK 19

 72 files  +1   72 suites  +1   4m 42s ⏱️ -4s
627 tests +2  617 ✅ +2  10 💤 ±0  0 ❌ ±0 
697 runs  +2  687 ✅ +2  10 💤 ±0  0 ❌ ±0 

Results for commit 8691e42. ± Comparison against base commit d03090c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test results on JDK 11

 72 files  +1   72 suites  +1   5m 10s ⏱️ -1s
627 tests +2  619 ✅ +2  8 💤 ±0  0 ❌ ±0 
697 runs  +2  689 ✅ +2  8 💤 ±0  0 ❌ ±0 

Results for commit 8691e42. ± Comparison against base commit d03090c.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 8.53659% with 225 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (d03090c) to head (8691e42).
Report is 2 commits behind head on neo.

Files with missing lines Patch % Lines
...ts/src/main/kotlin/org/jacodb/ets/utils/Handler.kt 5.90% 207 Missing ⚠️
.../src/main/kotlin/org/jacodb/ets/utils/GetLocals.kt 0.00% 11 Missing ⚠️
.../src/main/kotlin/org/jacodb/ets/utils/Collector.kt 61.53% 4 Missing and 1 partial ⚠️
.../src/main/kotlin/org/jacodb/ets/utils/GetValues.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #301      +/-   ##
============================================
- Coverage     70.36%   69.43%   -0.94%     
- Complexity     2471     2474       +3     
============================================
  Files           269      271       +2     
  Lines         15208    15450     +242     
  Branches       2274     2282       +8     
============================================
+ Hits          10701    10727      +26     
- Misses         3577     3791     +214     
- Partials        930      932       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lipen Lipen merged commit ad9d047 into neo Feb 5, 2025
8 of 10 checks passed
@Lipen Lipen deleted the lipen/collector branch February 5, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants