chore: bump to 4.7.8 - fix: return a new tenderly simulation status in case of tenderly downtime #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jsy1218
changed the title
jsy1218
force-pushed
the
siyujiang/tenderly-system-down-status
branch
from
eb2d4c7
to
6342aed
Compare
Merge activity
|
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (10/31/24)4 reviewers were added and 1 assignee was added to this PR based on 's automation. |
jsy1218
added a commit
to Uniswap/routing-api
that referenced
this pull request
Oct 31, 2024
…n case of tenderly downtime (#894) Release Uniswap/smart-order-router#759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Right now when tenderly has system downtime, we do not differentiate from when tenderly simulation returns a failed simulated transaction, in case of the Simulation Status, as FAILED.
What is the new behavior (if this is a feature change)?
In case of tenderly downtime, we return SystemDown simulation status from SOR.
Other information:
It will get populated in routing to return a new simulation status as "SYSTEM_DOWN"