chore: more granular metrics for routes/quotes fetched #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (10/30/24)1 reviewer was added and 1 assignee was added to this PR based on 's automation. |
jsy1218
reviewed
Oct 30, 2024
|
|
||
| metric.putMetric( | ||
| `MixedRoutesFetched_Chain_${this.chainId}`, | ||
| _(routesWithQuotes).sum() |
There was a problem hiding this comment.
number of routes with quotes should just be routesWithQuotes.length?
jsy1218
reviewed
Oct 30, 2024
| .sum() | ||
| ); | ||
|
|
||
| metric.putMetric(`V2RoutesFetched`, _(routesWithQuotes).sum()); |
There was a problem hiding this comment.
so this logs the routes fetched in case we have a cache routes miss. in case we have a cached routes hit, it will be within refreshRoutesThenGetQuotes.
I'm thinking (1) whether we should log routes and/or quotes fetched in case of cached routes hit (2) whether we should log both cached routes hit and cached routes miss
There was a problem hiding this comment.
makes sense - lets chat
|
good stuff, let's sync on the logging details |
|
discussed offline - will add logging in a different place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds more granular metrics for routes/quotes fetched.
This will give us more visibility on onChain effort, total routes, total quotes fetched per chain.
What is the current behavior? (You can also link to an open issue here)
Only logging number of quotes/latency at the top level
What is the new behavior (if this is a feature change)?
Logging quotes/routes/latency at top + per chain level.
Other information: