-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump sor to 4.7.5 - fix: cached routes cache invalidation #747
chore: bump sor to 4.7.5 - fix: cached routes cache invalidation #747
Conversation
i will add a test in alpha-router.integ-test. i have an idea how to repro this within SOR. this kind of test setup is first time, so it may take a bit of time. UPDATE - DONE! |
e72f865
to
ad517b2
Compare
2f638a7
to
fb994e9
Compare
fb994e9
to
e093753
Compare
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (10/17/24)4 reviewers were added and 1 assignee was added to this PR based on 's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - left few comments
… alpha router config
5236650
to
fb474ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach looks reasonable.
Left a couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
if the cached routes is invalid, meaning it cant get any swap route at all, it does not get cache invalidated.
What is the new behavior (if this is a feature change)?
we will invalidate the cached routes by checking to see if the swap route from cache is invalid
Other information:
we have to roll out with percentage. because there's a chance there are many invalid cached routes in prod.
This is somewhat critical to fix prior to V4, because there's a chance that routing caches invalid v4-pool routes. Previously this wasn't much of a concern,. since V3 launched in 2021, and cached routes was rolled out in 2023, so the v2 and v3 pool TVLs won't change that much, although concentrated liquidities can change based on the market pricing.
I expect with v4, there will be more dynamics from 0 TVL to some TVLs, hence cached routes have more chance of caching invalid v4-pool routes.