Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v4 subgraph on Sepelia in routing cron #808

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Aug 5, 2024

This is the minimum change in routing-api to support download v4 subgraph. I already verified in my local aws account to see the v4 subgraph getting downloaded:
Screenshot 2024-08-08 at 5 56 14 PM

@jsy1218 jsy1218 changed the title feat: v4 subgraph on Sepelia in routing cron (WIP) feat: v4 subgraph on Sepelia in routing cron Aug 5, 2024
Copy link
Member Author

jsy1218 commented Aug 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 marked this pull request as ready for review August 5, 2024 18:35
@jsy1218 jsy1218 changed the title (WIP) feat: v4 subgraph on Sepelia in routing cron feat: v4 subgraph on Sepelia in routing cron Aug 8, 2024
@graphite-app graphite-app bot requested review from xrsv, mikeki, cgkol and a team August 8, 2024 15:50
Copy link

graphite-app bot commented Aug 8, 2024

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (08/08/24)

5 reviewers were added and 1 assignee was added to this PR based on 's automation.

@jsy1218 jsy1218 force-pushed the siyujiang/route-213-download-v4-pools-from-subgraph-on-sepolia-in-routing-cron branch from f451f77 to 02e23cf Compare August 8, 2024 15:51
Copy link
Contributor

@xrsv xrsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - left a couple of comments

lib/cron/cache-config.ts Show resolved Hide resolved
lib/handlers/marshalling/route-marshaller.ts Outdated Show resolved Hide resolved
* chore(logging): log 500 error details

* add exception error log

* npm run fix:prettier
@jsy1218 jsy1218 force-pushed the siyujiang/route-213-download-v4-pools-from-subgraph-on-sepolia-in-routing-cron branch from 02e23cf to 6c467d9 Compare August 9, 2024 08:46
@jsy1218 jsy1218 merged commit 35d347f into main Aug 9, 2024
8 checks passed
@jsy1218 jsy1218 deleted the siyujiang/route-213-download-v4-pools-from-subgraph-on-sepolia-in-routing-cron branch August 9, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants