This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a vite app, an issue occurs when both
@uniswap/sdk-core
and@uniswap/router-sdk
are imported at the same time. A minimal repro can be found here: https://github.com/keithbro-imx/vite-uniswap-reproIn the browser, the following error is visible:
r
here is JSBI.Using yalc locally I was able to point at a local build of this library, and I get the error:
Not exactly the same error, but this was resolved by adding the
module
option to the package.json. After this, both libraries could be imported and used at the same time.I also added jsbi as a dependency (the same version constraints as core sdk for consistency), as this may also be contributing to the problem, though I wasn't able to confirm that.