Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log input parameters of specific failing methods #40

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Nov 27, 2023

For help in debugging #35 and #36.

Copy link

github-actions bot commented Nov 27, 2023

Test results

    3 files      3 suites   41s ⏱️
  62 tests   62 ✔️ 0 💤 0
186 runs  186 ✔️ 0 💤 0

Results for commit 0e1591f.

♻️ This comment has been updated with latest results.

@hmpf hmpf force-pushed the improve-exception-logging-in-functions branch from a11cfb1 to fd485b7 Compare November 27, 2023 11:54
@hmpf hmpf changed the title Log inout parameters of specific failing methods Log input parameters of specific failing methods Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (f066d26) 71.51% compared to head (0e1591f) 71.42%.
Report is 8 commits behind head on main.

Files Patch % Lines
src/zinolib/controllers/zino1.py 60.00% 14 Missing ⚠️
src/zinolib/ritz.py 27.77% 13 Missing ⚠️
src/zinolib/config/zino1.py 57.89% 8 Missing ⚠️
src/zinolib/utils.py 61.11% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   71.51%   71.42%   -0.09%     
==========================================
  Files          13       13              
  Lines        1271     1330      +59     
==========================================
+ Hits          909      950      +41     
- Misses        362      380      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmpf
Copy link
Contributor Author

hmpf commented Nov 27, 2023

Lacks tests, otherwise ready to go

Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/zinolib/utils.py Outdated Show resolved Hide resolved
src/zinolib/utils.py Outdated Show resolved Hide resolved
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hmpf hmpf requested a review from lunkwill42 November 27, 2023 12:41
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My "logging interpolation vs. f-strings muscle" hurts, but whatever :D

@hmpf hmpf merged commit 320562b into Uninett:main Nov 27, 2023
7 of 9 checks passed
@hmpf hmpf deleted the improve-exception-logging-in-functions branch November 29, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants