Make appliance build pipeline work on Ubuntu #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because macos-12 is deprecated on GitHub, and later macos images do not feature Virtualbox at all.
We no longer build for these distros.
This plugin was Python 2 specific and is no longer available on bullseye - and we don't need it either.
The `-e` wasn't working, becaus the she-bang was broken and the script is being passed as an argument to bash anyway. This changes to using `set -e`, so we can fail the build properly if any command in the script fails.
hmpf
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build stopped working a long time ago, and more cruft would accumulate.
The MacOS runner images were originally used because they were the only ones that would suppport VirtualBox and virtualization within virtualization. The macos-12 image we were dependent on has since been deprecated and macos-13, macos-14 and macos-15 have since been introduced: But these runners all operate on Apple Silicon and do not feature VirtualBox (which is an x86 hypervisor).
It seems the latest ubuntu runners do support virtualization within virtualization, so this updates the pipeline to build using Ubuntu instead.