-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show error message on trying to delete last dashboard #3232
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 9 files 9 suites 8m 28s ⏱️ Results for commit 7720f56. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3232 +/- ##
=======================================
Coverage 60.39% 60.40%
=======================================
Files 605 605
Lines 43683 43683
Branches 48 48
=======================================
+ Hits 26382 26385 +3
+ Misses 17289 17286 -3
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be some javascript shenanigans? |
Yeah nevermind, just my js scripts werent updated. Had to down-up the containers and now it works fine |
c499d88
to
7720f56
Compare
Quality Gate passedIssues Measures |
This is not an actual bug, but something I noticed when working on #3150.
The "Delete dashboard" button is already not shown when there is only one dashboard, so it is not possible for a user to try to delete their last dashboard.
So to reproduce this you need to change this line to actually show that button:
nav/python/nav/web/templates/webfront/index.html
Line 147 in 27b12b5
After that when trying to delete the last dashboard an alert box will be added with the content
[Object object]
instead of showing the correct error messageCannot delete last dashboard
.Before:
After: