This repository has been archived by the owner on Feb 11, 2025. It is now read-only.
Add meta description and keywords #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
johannaengland
approved these changes
Oct 28, 2024
| <meta name="description" | ||
| content="Argus is a tool for aggregating events from multiple monitoring applications into a single, unified dashboard and notification system."> | ||
| <meta name="keywords" | ||
| content="monitoring, notifications, dashboard, events, incidents, alerts, notifications, monitoring systems, monitoring applications, monitoring tools, monitoring software"> |
There was a problem hiding this comment.
My only complaint here is that you used notifications twice
And we could also use alarms
Apparently as of now it isn't used by SEs anymore
podliashanyk
force-pushed
the
add-meta
branch
from
6d48ca0 to
da8ebcb
Compare
johannaengland
approved these changes
Oct 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes complaints regarding rules H030 and H031 for #180.
Adding rules
H030andH031is very much nice-to-have-borderline-redundant as they concern search engine optimization. Argus runs in different instances and requires authentication so SEO is not a concern IMO.Meta keywords aren't even used as of now https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/The_head_metadata_in_HTML#adding_an_author_and_description.