-
Notifications
You must be signed in to change notification settings - Fork 4
Add and apply TailwindCSS Typography plugin #202
Conversation
As it crashes with existing styles, and isn't actually needed in the dashboard view
What's this about? |
Tailwind typography provides pretty and reasonable default styles for a set of HTML tags https://github.com/tailwindlabs/tailwindcss-typography. When combined with daisyUI we will get default results like here: https://daisyui.com/docs/layout-and-typography/#-1. In #190 (comment) we are discussing adding page headings to pages other than /incidents. This PR also applies typography styles to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial/gut reaction about using @tailwindcss/typography: Let's be really careful before adding this.
Reading the docs, it seems that the prose
class is meant for larger sections that have multiple headings, paragraphs, etc (such as content coming from a CMS or rendered markdown). It's called "prose" for a reason. The docs explicitly say that you probably don't want default prose styling, and I agree. The result is that now you need to not-prose large sections of the page, which seems like an antipattern.
If we want to apply some styles to headings because we want a heading system, that is fine, but I'd suggest creating classes for that and not just add style to tags by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read your comments about the typography plugin in my PR, but I'm not sure I understand the reasoning, given how the plugin is explained.
We're not about to add large sections of prose to Argus, so I find this a bit overkill just to style some page headings.
Agree with the comments above, furthermore putting it on Regarding the looks itself, I personally like the following compiled typography styles (for our headings system and for Uninett/Argus#1054):
With such a little subset of relevant styles let's just add our own classes. Although some typography plugin styles (for example for |
Should our styles have a prefix? "argus-"? |
I'm closing this... |
Relevant for Uninett/Argus#1054
Discussion:
<main>
by default?