Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear flapping functionality #85

Merged
merged 23 commits into from
Jun 7, 2024
Merged

Add clear flapping functionality #85

merged 23 commits into from
Jun 7, 2024

Conversation

podliashanyk
Copy link
Contributor

@podliashanyk podliashanyk commented Mar 18, 2024

Closes #66

Implemented changes:

  • Selected events are now stored as dict in session in order to keep info about type of selected events. This is because clear flapping functionality is only applicable to portstate events. Therefore clear flapping button in bulk menu is shown only if all selected events are of type portstate.
  • Enabled clear flapping button in detailed event view for portstate events.
  • Removed clear flapping button from detailed event view for events that are not portstate.

@podliashanyk podliashanyk added enhancement New feature or request beta Part of beta release labels Mar 18, 2024
@podliashanyk podliashanyk self-assigned this Mar 18, 2024
Copy link

github-actions bot commented Mar 18, 2024

Test results

  4 files    4 suites   8s ⏱️
14 tests 14 ✔️ 0 💤 0
56 runs  56 ✔️ 0 💤 0

Results for commit f77209c.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 16.07143% with 47 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@0f25da1). Learn more about missing BASE report.

Files Patch % Lines
src/howitz/endpoints.py 16.07% 47 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage        ?   47.30%           
=======================================
  Files           ?       15           
  Lines           ?      890           
  Branches        ?        0           
=======================================
  Hits            ?      421           
  Misses          ?      469           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@podliashanyk podliashanyk marked this pull request as ready for review March 21, 2024 12:38
src/howitz/endpoints.py Outdated Show resolved Hide resolved
src/howitz/endpoints.py Outdated Show resolved Hide resolved
@podliashanyk podliashanyk requested a review from hmpf April 5, 2024 14:50
src/howitz/endpoints.py Show resolved Hide resolved
src/howitz/endpoints.py Outdated Show resolved Hide resolved
@podliashanyk podliashanyk requested a review from hmpf May 22, 2024 09:47
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some python syntax nitpicks this time around.

src/howitz/endpoints.py Outdated Show resolved Hide resolved
src/howitz/endpoints.py Outdated Show resolved Hide resolved
src/howitz/endpoints.py Outdated Show resolved Hide resolved
@podliashanyk podliashanyk requested a review from hmpf May 29, 2024 14:07
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Works as long as I merge with main first...

@podliashanyk podliashanyk merged commit 2c1ea85 into main Jun 7, 2024
5 checks passed
@podliashanyk podliashanyk deleted the add-clear-flapping branch June 7, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Part of beta release enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clear flapping functionality
4 participants