-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sorting of events via config file #81
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage ? 48.60%
=======================================
Files ? 16
Lines ? 1004
Branches ? 0
=======================================
Hits ? 488
Misses ? 516
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Bad code and not all sorting results are equivalent to sorting results in nowadays Zino TK
All sorting methods are implemented and work as intended
Sorting method is configured as sort_by (str) under [howitz] section.
double underscore in _value_ holds some meaning for Enum, but the other ones seem unecessary
ff0f4f1
to
ab3a76a
Compare
In order to avoid circular imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will rereview after rebase.
NTS: tests, the big if
86e2f65
to
eed57be
Compare
Otherwise, the logger.debug statement in sorted_events() fails with RuntimeError
21a54cc
to
482a46c
Compare
Contains xml files with coverage reports and results
Related discussion #96
Depends on Uninett/zinolib#61
Implemented changes:
SimpleCache
from flask-caching)Attention needed:
endpoints.py
?Further work:
Make it possible to change sorting method via web UI(not a part of original implementation in Curitz)