Make it possible to change sorting method via UI #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make spacing prettier, add id to content div (for HTMX)
|
I will test this manually. |
podliashanyk
changed the title
Necessary when there is no sort_by provided in the config
hmpf
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Seems to be working fine but when sorting on "severity" I anticipate confused new users (as I was confused) so we need to document what sorting on severity means in some fashion that does not take programming experience.
"'severity' takes into account both x, y and z so there might not be continuous blocks of color" or something like that.
podliashanyk
force-pushed
the
change-sorting-ui
branch
from
187b4ad to
0b9b091
Compare
hmpf
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68
Implemented changes: