Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create destination form generating extra div when submitting #1127

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Jan 15, 2025

Fixes #1129

@stveit stveit added the bug Something is not working as expected label Jan 15, 2025
@stveit stveit self-assigned this Jan 15, 2025
@johannaengland
Copy link
Contributor

This related to #970

@johannaengland johannaengland changed the title Fix create form generating extra div when submitting Fix create destination form generating extra div when submitting Jan 15, 2025
Copy link

Test results

   10 files  1 050 suites   37m 58s ⏱️
  532 tests   531 ✅  1 💤 0 ❌
5 320 runs  5 310 ✅ 10 💤 0 ❌

Results for commit a01ced4.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (84da7a2) to head (a01ced4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1127   +/-   ##
=======================================
  Coverage   79.83%   79.83%           
=======================================
  Files         145      145           
  Lines        5267     5267           
=======================================
  Hits         4205     4205           
  Misses       1062     1062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stveit stveit merged commit 2b8a879 into master Jan 15, 2025
17 checks passed
@stveit stveit deleted the fix-create-htmx-creating-duplicate-divs branch January 15, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create destination form creates duplicate div when submitting
3 participants