Only update affected media list when deleting destination in HTMX frontend #1120
+38
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results 10 files 1 060 suites 38m 7s ⏱️ Results for commit 4e46505. ♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
- Coverage 79.71% 79.67% -0.05%
==========================================
Files 141 141
Lines 5285 5288 +3
==========================================
Hits 4213 4213
- Misses 1072 1075 +3 ☔ View full report in Codecov by Sentry. |
stveit
force-pushed
the
htmx-destination-delete-only-affected-row
branch
from
a4325bf to
fdfda05
Compare
stveit
commented
Jan 13, 2025
stveit
force-pushed
the
htmx-destination-delete-only-affected-row
branch
2 times, most recently
from
e1fba78 to
796cf8c
Compare
stveit
changed the title
|
Updated this PR quite drastically: Now refreshes the list and not only the row |
johannaengland
approved these changes
Jan 15, 2025
stveit
force-pushed
the
htmx-destination-delete-only-affected-row
branch
from
71b7284 to
1cccf5e
Compare
This was added so the "This destination cannot be deleted error" could be shown separate from field specific errors, but after the changes done to the delete endpoint this is no longer used. _render_destination_list is complicated enough as-is that removing this makes it a bit nicer
stveit
force-pushed
the
htmx-destination-delete-only-affected-row
branch
from
1cccf5e to
4e46505
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1128
Makes it so only the media list for the destination you try to delete is updated with HTMX. If it is deleted succesfully, it just disappears. If it cannot be deleted, a error message is shown at the top of the list.
There was supposed to already be an error message if a destination could not be deleted, but the location of the error message in the templates did not match up with the template used for HTMX when deleting, so the error message was never actually shown prior to this PR, so this PR is also effectively a bugfix to that.