Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use apt-get to install towncrier #589

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

johannaengland
Copy link
Contributor

This has become necessary due to PEP 668.

Example where currently the towncrier check fails: https://github.com/Uninett/Argus-frontend/actions/runs/11360341158/job/31602238891?pr=586

@johannaengland johannaengland added the bug Something is not working as expected label Oct 16, 2024
@johannaengland johannaengland self-assigned this Oct 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.34%. Comparing base (8403776) to head (7f00333).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #589   +/-   ##
=======================================
  Coverage   57.34%   57.34%           
=======================================
  Files          86       86           
  Lines        3692     3692           
  Branches      839      840    +1     
=======================================
  Hits         2117     2117           
  Misses       1566     1566           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland force-pushed the workflows/fix-pip-install-towncrier branch from cddc17b to 7f00333 Compare October 16, 2024 12:49
@johannaengland johannaengland changed the title Fix pip install towncrier by passing break-system-packages flag Use apt-get to install towncrier Oct 16, 2024
Copy link

@hmpf hmpf merged commit 94385c4 into master Oct 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants