Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous Cleanups #830

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Miscellaneous Cleanups #830

wants to merge 11 commits into from

Conversation

dopplershift
Copy link
Member

@dopplershift dopplershift commented Nov 8, 2024 •
edited
Loading

Description Of Changes

  • Remove outdated Travis (and AppVeyor) info
  • Remove outdated TODO.md
  • Make linkchecker pass (Fixes Nightly build is failing #828)
  • Clean up deprecation warnings from utcnow()
  • Clean up suppression of warnings related to setting .units on DataFrames
  • Make test suite run with warnings as errors

Checklist

@dopplershift dopplershift added this to the 0.10 milestone Nov 11, 2024
dcamron
dcamron requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess they don't call it codegrammar

docs/developerguide.rst Outdated Show resolved Hide resolved
docs/developerguide.rst Outdated Show resolved Hide resolved
@dopplershift
MNT: Replace Travis/AppVeyor mentions with GHA
e82bc09
@dopplershift
MNT: Remove TODO.md
7d3a89a 
This hasn't been touched in 9 years and is out of date.
@dopplershift
DOC: Clean up linkcheck redirects
f2e95bf
@dopplershift
MNT: Replace uses of datetime.utcnow()
8df8766 
For examples, switch to proper now(timezone.utc). In tests, timezone
does not actually matter in those tests, so just use the simpler now().
@dopplershift
DOC: Fix up type in docstring
4b7d311 
This fixes a code analysis error in PyCharm.
@dopplershift
MNT: Ignore sphinx-gallery generated file
3e86541
@dopplershift
MNT: Be more specific filtering pandas warning
54f9eb2 
Use a context manager to only filter at the time we set the units
attribute, which minimizes impact. It also helps silence warnings when
running the test suite.
@dopplershift
MNT: Make default test suite config more picky
a2b5307 
Set xfail_strict to true and also make warnings trigger errors.
@dopplershift
MNT: Bump minimum xarray to 2022.6.0
c7bac25 
Cleans up a warning with little change in the support window.
@dopplershift
MNT: Clean up some issues found by CodeQL
fa4f169
@dopplershift
Copy link
Member Author

In addition to addressing the review comments, I went ahead and pushed a commit that enables Sphinx nitpicky mode and cleans up all of the issues that identified.

@dopplershift
MNT: Enable Sphinx nitpicky mode
74b01ef 
Also clean up a bunch of issues with references found by nitpicky mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesserwhirls lesserwhirls Awaiting requested review from lesserwhirls lesserwhirls is a code owner

@dcamron dcamron Awaiting requested review from dcamron dcamron is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

Nightly build is failing
2 participants
@dopplershift @dcamron