-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix many warnings in libnczarr #2852
base: main
Are you sure you want to change the base?
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 51073cb - Browse repository at this point
Copy the full SHA 51073cbView commit details -
Change
len
member ofNC_ATT_INFO_T
tosize_t
More consistent with similar structs, and generates fewer warnings
Configuration menu - View commit details
-
Copy full SHA for 013af12 - Browse repository at this point
Copy the full SHA 013af12View commit details -
Switch some
int/mode_t
confusionSome mix-up here: `mode_t` was used for some netCDF-specific modes, and `int` used for some POSIX-specific modes
Configuration menu - View commit details
-
Copy full SHA for 585e322 - Browse repository at this point
Copy the full SHA 585e322View commit details -
Fix some sign conversion warnings in libnczarr functions/types
Try to be more consistent in use of `size_t` across internal library declarations
Configuration menu - View commit details
-
Copy full SHA for 3537781 - Browse repository at this point
Copy the full SHA 3537781View commit details
Commits on Mar 12, 2024
-
Fix loop conditional in
NCZ_filter_finalize
`loaded_plugins_max` is *not* the total number of loaded plugins, but the max ID, and defaults to `-1`. This clashes with the change of the index to `size_t`
Configuration menu - View commit details
-
Copy full SHA for f8da95a - Browse repository at this point
Copy the full SHA f8da95aView commit details
Commits on Mar 25, 2024
-
Merge branch 'main' into silence-libnczarr-warnings
* main: (248 commits) Updated Release Notes. A bit of cleanup for now, more to follow, but moving on to other roadblocks. Comment out debugging messages, will remove before final merge. Clean up the logic, remove some rough edges. Add a filter to process options and report deprecation warning. Remove dangling define in netcdf_meta.h template file. No effect other than to remove a personal annoyance I introduced in the first place. Updated the nc-config script with the following: adding deprecation error for usage of NETCDF_ENABLE_NETCDF4 removing cmake alias variable for netcdf4 removing script replacing something that removes semicolons another one fixing some that were missing? removing variables Replacing NC_USE_STATIC_CRT with NETCDF_USE_STATIC_CRT Replace NC_FIND_SHARED_LIBS with NETCDF_FIND_SHARED_LIBS Replace ENABLE_XGETOPT with NETCDF_ENABLE_XGETOPT Replace ENABLE_UNIT_TESTS with NETCDF_ENABLE_UNIT_TESTS Replace ENABLE_TESTS with NETCDF_ENABLE_TESTS Replace ENABLE_STRICT_NULL_BYTE_HEADER_PADDING with NETCDF_ENABLE_STRICT_NULL_BYTE_HEADER_PADDING ...
Configuration menu - View commit details
-
Copy full SHA for 0df2958 - Browse repository at this point
Copy the full SHA 0df2958View commit details -
Conditionally mark variable as unused
Also delete actually unused variable
Configuration menu - View commit details
-
Copy full SHA for dac5355 - Browse repository at this point
Copy the full SHA dac5355View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7c1c78 - Browse repository at this point
Copy the full SHA e7c1c78View commit details