-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thread-safe execution support to netcdf-c #2505
Open
DennisHeimbigner
wants to merge
226
commits into
Unidata:main
Choose a base branch
from
DennisHeimbigner:threadsafe.dmh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is experimental and should be used with caution.
It implements thread-safety with a mechanism similar to that used by HDF5. There is a single global mutex object that controls access to the netcdf API. It effectively serializes all calls to the API. For *nix* operating systems, it uses pthreads and more specifically the pthread_mutex functionality. For Windows it uses the built-in CriticalSection API.
The controlling option is "--enable-threadsafe" in Automake and "-DENABLE_THREADSAFE=on" in CMake. In this PR, it is enabled by default, but if it ever moves into production, it will be disabled by default.
Github Actions
Local build and test of this PR is known to work on Ubuntu-21 and Visual Studio. Build and test on Github Actions is currently failing for all systems. Fixing will require interactive access to the relevant platform.
Testing
This PR has had minimal testing; I am hoping that others can help out. There is one test case included: nc_test/run_threads.sh, which uses nc_test/tst_threads.c.
The primary functionality is in libdispatch/dmutex.c. It has some debug flags enabled to match lock with unlock to detect paths that bypass locking.
Warnings
Documentation
For more detailed documentation see netcdf-c/docs/threadsafe.md
Addendum (5/31/2023)
Add some more improvements.