Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Build wheels against NumPy 2.0 #326

Closed
wants to merge 1 commit into from
Closed

MAINT: Build wheels against NumPy 2.0 #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/cibuildwheel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:
python -c "import cftime; print(f'cftime v{cftime.__version__}')" &&
python -m pip install check-manifest cython pytest pytest-cov &&
python -m pytest -vv {package}/test
CIBW_BUILD_FRONTEND: 'pip; args: --pre --extra-index-url "https://pypi.anaconda.org/scientific-python-nightly-wheels/simple"'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part (or something like it) is necessary if you want to release before 2.0 actually lands

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pypi.org/project/numpy/2.0.0rc1/#files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh yes you're right I forgot it's on PyPI proper now 🤦

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being proactive and for helping with this. I am also looking forward to a numpy 2 compatible release. Just trying to save you time.


- uses: actions/upload-artifact@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests_conda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
platform: [x64, x32]
experimental: [false]
exclude:
- os: macos-latest
- os: macos-latest
platform: x32
include:
- python-version: "3.12"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests_latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ jobs:
--index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/ \
--trusted-host pypi.anaconda.org \
--no-deps --pre --upgrade \
numpy
"numpy>=2.0.0.dev0"

- name: Install cftime
run: |
python -m pip install .
python -m pip install --no-build-isolation .

- name: Test cftime
run: |
Expand Down