-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixed-layer CAPE/CIN accepts depth in units of height #1912
base: main
Are you sure you want to change the base?
Conversation
mixed_layer_cape_cin() can handle `depth` in units of height passed through kwargs. This works regardless of whether a `height` profile is provided.
9d95c5b
to
4ef8ce4
Compare
While we're taking a look at
The possible kwargs for In If this analysis is correct, I see two possible options:
|
I'm currently trying to figure out how I wasn't aware of |
It looks like
On the other hand, The more I look into this, the less clear it is. Will try to spend some more time on this. |
So |
logarithmically interpolated. Kwargs for `mixed_parcel` can be provided, such as `depth`. | ||
Default mixed-layer depth is 100 hPa. | ||
logarithmically interpolated. Kwargs for `mixed_parcel` can be provided, such as `depth` | ||
and `height`. Default mixed-layer depth is 100 hPa. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the name of the height
kwarg it is not clear that this represents an array of height values associated with a vertical profile. Would a variable name of height_profile
be more appropriate and descriptive for our users? I think this would also help alleviate some confusion between that kwarg and depth
as they are clearly distinct.
Previously,
mixed_layer_cape_cin()
only supported layer depth as a pressure. To be consistent withmixed_parcel()
, which takes depth as a height or pressure, this PR adds the ability to provide layer depth as a height.If the depth is in units of height, it would be nice to have a height profile passed in as well. However, in the case that a height profile is not passed, a warning is issued to let the user know that their height was converted to pressure with
height_to_pressure_std()
.Full disclosure: I haven't taken any thermo classes, so this PR is the product of many Google searches and probably has some errors that I didn't catch. Please don't hesitate to point those out, and provide any other comments as well.
Checklist