Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of @spcfox's modal logic pull request #1170

Draft
wants to merge 68 commits into
base: master
Choose a base branch
from

Conversation

EgbertRijke
Copy link
Collaborator

@spcfox made an impressive pull request, but unfortunately we haven't heard from him since. This is an attempt to bring his pull request to a mergeable state.

@fredrik-bakke
Copy link
Collaborator

Very glad that someone is taking care of this! Do you want a third pair of eyes to look at this before it is merged?

@spcfox
Copy link

spcfox commented Aug 29, 2024

Hello!
I am very glad that my contribution is important to you. I would be very interested in completing this pull request, but unfortunately for personal reasons I do not have the energy to do so right now.

@EgbertRijke
Copy link
Collaborator Author

Hi @spcfox!

I'm glad to hear from you and I hope you are doing well. You have made a heroic effort with your pull request, and indeed I am very happy to take on the task towards merging it. I completely understand that a personal situation might be getting in the way, and you don't need to worry about the pull request if you don't have the energy for it. We will make sure that you will be appropriately attributed for the work that you have done.

Take care, and I hope to hear from you again sometime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants