Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check that tests for Physical parts during Depot-Connecting #1569

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/WOLF/WOLF/Messenger.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace WOLF
public static class Messenger
{
public static string INVALID_DEPOT_PART_ATTACHMENT_MESSAGE = "#autoLOC_USI_WOLF_INVALID_DEPOT_PART_ATTACHMENT_MESSAGE"; // "Depots must be detached from other WOLF parts before deployment.";
public static string INVALID_HOPPER_PART_ATTACHMENT_MESSAGE = "#autoLOC_USI_WOLF_INVALID_HOPPER_PART_ATTACHMENT_MESSAGE"; // "Hoppers must be detached from other WOLF parts before deployment.";
public static string INVALID_HOPPER_PART_ATTACHMENT_MESSAGE = "#autoLOC_USI_WOLF_INVALID_HOPPER_PART_ATTACHMENT_MESSAGE"; // "Physical WOLF-connected parts (like hoppers and terminals) must be detached from other WOLF parts (like depots and converters) before deployment.";
public static string INVALID_SITUATION_MESSAGE = "#autoLOC_USI_WOLF_INVALID_SITUATION_MESSAGE"; // "Your vessel must be landed or orbiting in order to connect to a depot.";
public static string INVALID_ORBIT_SITUATION_MESSAGE = "#autoLOC_USI_WOLF_INVALID_ORBIT_SITUATION_MESSAGE"; // "Your vessel must be in a low orbit with eccentricity below 0.1 to connect to a orbital depot.";
public static string MISSING_DEPOT_MESSAGE = "#autoLOC_USI_WOLF_MISSING_DEPOT_MESSAGE"; // "You must establish a depot in this biome first!";
Expand Down
3 changes: 2 additions & 1 deletion Source/WOLF/WOLF/Modules/WOLF_ConverterModule.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ protected string CanConnectToDepot()
return Messenger.INVALID_DEPOT_PART_ATTACHMENT_MESSAGE;
}
var otherHopperModules = vessel.FindPartModulesImplementing<WOLF_HopperModule>();
if (otherHopperModules.Any())
var otherTerminalModules = vessel.FindPartModulesImplementing<WOLF_TerminalModule>();
if (otherHopperModules.Any() || otherTerminalModules.Any())
{
return Messenger.INVALID_HOPPER_PART_ATTACHMENT_MESSAGE;
}
Expand Down