Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contourf for matplotlib 3.10 (fixes Issue #14) #15

Closed
wants to merge 3 commits into from
Closed

Fix contourf for matplotlib 3.10 (fixes Issue #14) #15

wants to merge 3 commits into from

Conversation

austin-hoover
Copy link

No description provided.

beckermr
beckermr requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to be careful about changes here since we don't know the code base. This looks like it will break other things and certainly would be wrong for earlier MPL versions.

@austin-hoover
Copy link
Author

Ah, I forgot about older matplotlib.

@austin-hoover
Copy link
Author

@beckermr I didn't mean to request another review; clicked accidentally.

@beckermr
Copy link
Collaborator

You can set this to draft and keep working if you'd like!

@austin-hoover austin-hoover changed the title Fixes #14 Fix contourf for matplotlib 3.10 (fixes #14) Jan 10, 2025
@austin-hoover austin-hoover changed the title Fix contourf for matplotlib 3.10 (fixes #14) Fix contourf for matplotlib 3.10 (fixes Issue #14) Jan 10, 2025
@austin-hoover
Copy link
Author

i don't see the "convert to draft" button under "Reviewers" section. I think you need to respond to the request I accidentally sent?

@beckermr beckermr reopened this Jan 10, 2025
beckermr
beckermr requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As before...

@austin-hoover austin-hoover marked this pull request as draft January 10, 2025 23:28
@beckermr beckermr marked this pull request as draft January 10, 2025 23:28
@beckermr
Copy link
Collaborator

done!

@cvanelteren
Copy link
Contributor

I have this issue actually on my todos; mpl indicates that this has been indicated from 3.8 onward. As main is compatible with 3.9.x, I think it is safe to move forward with this as long as we tag the version that we drop compatibility with mpl 3.8. However, this PR may be to premature as I haven't tested things on 3.10 yet.

@cvanelteren
Copy link
Contributor

To clarify my previous response. Ultraplot itself also indicates some deprecation warnings, I think we should in one swoop clean ultraplot of these things and ensure backwards compatibility and or update them accordingly.

@cvanelteren cvanelteren mentioned this pull request Jan 11, 2025
Merged
@cvanelteren
Copy link
Contributor

Closing in favor of #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austin-hoover @beckermr @cvanelteren