Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Syntax of the #VERSION Header #55

Merged
merged 1 commit into from
May 5, 2024

Conversation

codello
Copy link
Contributor

@codello codello commented May 4, 2024

What does this PR do?

This PR clarifies the supported and intended syntax of the #VERSION header.
Following the discussion in #13 this PR clarifies that valid values of the version header look like 1.2.3 and are intended to be have similarly to SermVer. However not all of the SemVer syntax is being used (e.g. prereleases).

Closes Issue(s)

Relates to #13.

Motivation

I feel like stating that the #VERSION header can be any valid SemVer is misleading if there is no intent of making use of prereleases or metadata. Having the syntax stated more clearly avoids misunderstandings and simplifies implementations.

@marwin89 marwin89 self-requested a review May 5, 2024 07:38
Copy link
Collaborator

@marwin89 marwin89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Approved :)

@marwin89 marwin89 merged commit 23bf930 into UltraStar-Deluxe:main May 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants