Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Songlist webserver #911

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

irgendwr
Copy link

based on / continuation of #852

Contributions are welcome! feel free to reach out if you're interested

Additions:

  • (improved performance of original prototype)
  • dark/light theme
  • added cover/background/audio/video/file API: /song/<index>/<cover/background/audio/video/file
  • added JSON API: /songlist.json
  • (implemented HTTP routing)

What's still missing:

  • good UI/UX
    • add a cover grid view, especially for mobile
    • better list view (with cover and more details)
    • show more details on click + audio (and video?) preview
  • option to add song into a queue (or alternatively a playlist at first)
  • add config options:
    • enable/disable the webserver
    • change the port
    • (dis-)allow queue
    • (dis-)allow audio/video preview
  • maybe show a QR code in the UI for ease of sharing?

Known issues:

  • something is wrong with the try catches. no response is sent on errors

@bohning
Copy link
Collaborator

bohning commented Oct 10, 2024

Woohoo, thanks a lot for picking up on this and your contributions!

//------------------------------
Log.LogStatus('Webserver', 'Initialization');
// Create and start the web server
Server := TWebServer.Create(8091);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the port configurable, but set it to strictly only listen on localhost. If people want to have it reachable over network, this forces them to put at the very least a tiny bit of effort into setting up a reverse proxy, which then hopefully has much less attack surface than the old UWebServer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants