Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed outdated packages from manifest.json #469

Closed
wants to merge 1 commit into from

Conversation

qamil95
Copy link

@qamil95 qamil95 commented Sep 2, 2024

What does this PR do?

Removes outdated packages from package.json, just to try what would happen.

Closes Issue(s)

Nothing, only trying to check why build is failing.

Motivation

No possibility to download UltraStar Play after merging melody mania changes.

More

  • Added/updated documentation

Additional Notes

Could you approve starting build? I don't have unity license so I can't run it on my forked branch, I also don't know if it would resolve the issue but why not check?

@achimmihca
Copy link
Collaborator

I don't understand what you try to achieve with this PR.

At least com.unity.render-pipelines.universal is important to build the project. This is the rendering pipeline used for the Unity project.

No possibility to download UltraStar Play after merging melody mania changes.

You can still download v0.9.0 of UltraStar Play.

Further, you can create a more recent build by yourself that includes the merged code from Melody Mania.
Therefore, follow the instructions in the wiki: https://github.com/UltraStar-Deluxe/Play/wiki/Download-and-Install#download-and-build-from-source-code

Only reason that there is no updated, ready to use build yet is that nobody took the time to create it.
UltraStar Play is welcoming maintainers of the build (e.g. DevOps stuff).

Anyway, no changes to the package.json should be needed.

@achimmihca
Copy link
Collaborator

achimmihca commented Sep 2, 2024

I don't have unity license so I can't run it on my forked branch

There is a free license available that should get you started.

I also don't know if it would resolve the issue but why not check

Not sure what you mean. But if you mean the failing pipeline, then this is mostly due to failing tests because of #435
One short-term workaround might be to disable the tests. But it is not a graceful solution.

@AnsisMalins
Copy link
Collaborator

I'm closing this pull request because it is superseded by my pull requests that remove even more packages. You have the right idea though, qamil95. Re: Universal Render Pipeline: it can be removed, but then its configuration assets need to be removed too, else they will be left dangling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants