-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voron volumetric speed #20023
base: main
Are you sure you want to change the base?
Voron volumetric speed #20023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
"acceleration_support": { "value": "math.ceil(acceleration_print / 2)" }, | ||
"acceleration_travel": { "value": "acceleration_print if magic_spiralize else min(math.ceil(acceleration_print * 7000 / 5000), round((machine_max_acceleration_x + machine_max_acceleration_y) / 2, -2))" }, | ||
"acceleration_wall_0": { "value": "math.ceil(acceleration_wall * 3000 / 5000)" }, | ||
"adhesion_type": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm doing something wrong, but it appears that there is an issue with adhesion_type
not recognizing the values when written this way. Seen in the cura log as NameError: name 'skirt' is not defined
. Tested on Cura 5.9 and 5.10-alpha in Windows.
I was able to fix it and adhesion works properly by deleting default_value and adding quotes around each string value:
"adhesion_type": { "value": "'brim' if draft_shield_enabled else 'skirt'" },
Example of other printers doing it this way:
"adhesion_type": { "value": "'none' if support_enable else 'skirt'" }, |
"adhesion_type": { "value": "'none' if support_enable else 'skirt'" }, |
If this is an error on my parts somewhere, I really apologize for wasting your time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct about the single quotes, I have fixed that error before, so I am surprised it is missing from this branch. Thank you for pointing it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, after some more testing, I was able to verify that default_value
does work correctly. It seems the only issue was the quotes. Logs are clear now. Sorry for that part.
You're welcome, glad it helped! Your pull request has helped me as a reference for better default settings for Cura profile for the Peopoly Magneto X printer. Thank you for your work!
Description
This updates the Voron base definition files and material profiles to make better use of the latest features and defaults inherited from
fdmprinter.def.json
. The goal is to simplify the printer definition, reduce the number of redundant lines of code, and replace hard-coded values with parametric definitions so that the base printer definition can more effectively adapt to custom Voron printer configurations. I have also designed the behavior of these printer definitions to be more consistent with the community-made Voron definitions found in other open-source slicers, to keep these definitions up-to-date with the changes and improvements that have been made to both the Voron printer hardware and Voron support/compatibility seen on other slicers.I have chosen the parametric print speeds so that they result in the exact same print speeds as the previous hard-coded values. This ensures that print speeds continue to be calculated appropriately for other combinations of nozzle sizes and layer heights that are not yet standardized in this printer definition, while keeping this new printer definition fully backwards-compatible with existing Voron users' custom print/material profiles.
Type of change
How Has This Been Tested?
print_speed
values for all the supported material types.cool_min_speed
,travel_speed
, etc.), I manually checked the values displayed in the slicer when using different combinations of printers, nozzle sizes, layer heights, and material types to ensure that they were calculated to the results I intended.Test Configuration:
Checklist: