Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cura 12255 string fix translation #19846

Merged
merged 9 commits into from
Nov 7, 2024
Merged

Conversation

HellAholic
Copy link
Contributor

@HellAholic HellAholic commented Nov 1, 2024

@HellAholic HellAholic changed the base branch from main to 5.9 November 1, 2024 14:55
Unclear where it's used and should be kept
Text was assigned directly from the Machine manager without being passed to the catalog
resources/i18n/cs_CZ/fdmprinter.def.json.po Outdated Show resolved Hide resolved
resources/i18n/cs_CZ/fdmprinter.def.json.po Outdated Show resolved Hide resolved
CURA-12255
Also applied some consistency between labels, so that they are more consistent and more printers get their variants name translated.
@wawanbreton
Copy link
Contributor

We now have only 3 translated variants names:

  • "Nozzle Size", used by default
  • "Print Core", used by UM printers
  • "Extruder", used by MB printers

@HellAholic HellAholic merged commit 32833df into 5.9 Nov 7, 2024
8 checks passed
@HellAholic HellAholic deleted the CURA-12255_string_fix_translation branch November 7, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants