Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanner customnametag #148

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Scanner customnametag #148

merged 4 commits into from
Aug 15, 2024

Conversation

prithviulm
Copy link
Contributor

Description

Added a UI element in the scanner GUI for the user to specify a custom save file name for saved scans. Note that this is only appended to the default nametag that is generated which contains the timestamp.

Motivation and Context

Some users do multiple confocal scans and it is difficult to keep track of the scans since they are only saved with timestamps in the file name.

How Has This Been Tested?

Tested on Ubuntu 22.04.4LTS with dummy modules and on Windows 10 (custom config for experiments) and it works fine in both. Note that the UI changes made here were based on those in the ODMR GUI.

Types of changes

  • Bug fix
  • New feature
  • Breaking change (Causes existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in /docs/changelog.md.
  • My change requires additional/updated documentation.
  • I have updated the documentation accordingly.
  • I have added/updated the config example for any module docstrings as necessary.
  • I have checked that the change does not contain obvious errors
    (syntax, indentation, mutable default values, etc.).
  • I have tested my changes using 'Load all modules' on the default dummy configuration.
  • All changed Jupyter notebooks have been stripped of their output cells.

@prithviulm prithviulm requested a review from timoML August 6, 2024 09:22
@prithviulm prithviulm added the enhancement New feature or request label Aug 6, 2024
Copy link
Contributor

@timoML timoML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you document the maintenance team discussion on a long term saving overhaul somewhere (e.g. Issues)?

@prithviulm prithviulm merged commit 6c3cd15 into main Aug 15, 2024
@prithviulm prithviulm deleted the scanner_customnametag branch August 15, 2024 09:16
@prithviulm
Copy link
Contributor Author

Looks good. Can you document the maintenance team discussion on a long term saving overhaul somewhere (e.g. Issues)?

This is now tracked under #150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants