-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Code Quality #795
Improve Code Quality #795
Conversation
@ EliotJones Ready for review / feedback. |
@EliotJones I did a quick review and it looks good to me. I think it's about time we drop out of support framework, so this is a great opportunity to do so |
Purely on the subject of TFMs
|
With net6.0 going out of support in November (of this year), what do we think about bumping the testing target to .NET8.0 as well? .NET8.0 will be supported until November 2026.
|
@iamcarbon I think it's safe to drop the net6.0 test target for the net8.0 Also, the tests are now failing... might be related, I think there's an issue in the yaml change: seems like it cannot target 2 different dotnet versions (only target net8.0 then?) As a side note, I think it's better to not make this PR too much bigger for ease of review. The great job you did with span opens a lot of optimisation which can be done in later PRs I'll let @EliotJones give his opinion on obsolete framework version. I need to review the changes more thoroughly but I'd be happy to merge the PR as it is I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes
This PR:
https://learn.microsoft.com/en-us/lifecycle/products/microsoft-net-framework