Add more classes to the Public API #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliotJones
reviewed
Oct 22, 2023
| { | ||
| return null; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// The page media box. | ||
| /// </summary> | ||
| public MediaBox MediaBox { get; set; } |
There was a problem hiding this comment.
Could these property setters be internal to stop consumers messing with them?
There was a problem hiding this comment.
well spotted, now updated
|
@BobLd on |
|
@EliotJones good point on the resource store instance, I'll look into it and create another PR for that. Let's keep this one simple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #656.
I've done the changes in several commits - that might help the review. I'll squash them when merging.
I've also update
NamedDestinationsnamespace to match folder structure. Feel free to let me know if that should not the case.For the moment,
IPageFactorystays internal, mainly becauseInternalParsingOptionsis. Same forIResourceStore(and relatedXObjectFactory).@EliotJones what's your view on
InternalParsingOptions? I don't want to make it public but we will need to find a way to makeIResourceStoreandIResourceStorepublic