Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase concurrency in controllers, make sqlite datastore default #79

Merged
merged 7 commits into from
Nov 22, 2023

Conversation

waveywaves
Copy link
Member

@waveywaves waveywaves commented Nov 22, 2023

  • update concurrent reconciliations for the helm controller from 5 to 20
  • cleanup some of the main.go
  • update date concurrent reconciliations for the uffizzicluster controller from 1 to 5
  • sqlite as the default externalDatastore

Note the worker count in the uffizzicluster controller before and after. The default number of workers has been set to 5.

Updated uffizzi cluster worker count

2023-11-22T11:19:53Z    DEBUG   events  pr-79-uffizzi-cluster-operator-5fcc7bd77b-52zt8_e5592983-09ee-42e1-9731-a87930fbb1cb became leader    {"type": "Normal", "object": {"kind":"Lease","namespace":"default","name":"bfbf93f2.uffizzi.com","uid":"1d6999de-703d-435a-9f87-39220da52312","apiVersion":"coordination.k8s.io/v1","resourceVersion":"1230"}, "reason": "LeaderElection"}
2023-11-22T11:19:53Z    INFO    Starting workers        {"controller": "uffizzicluster", "controllerGroup": "uffizzi.com", "controllerKind": "UffizziCluster", "worker count": 5}
2023-11-22T11:19:53Z    INFO    Starting workers        {"controller": "uffizzicluster", "controllerGroup": "uffizzi.com", "controllerKind": "UffizziCluster", "worker count": 5}

Updated helm controller worker count

{"level":"info","ts":"2023-11-22T11:09:26.904Z","msg":"Starting Controller","controller":"helmrelease","controllerGroup":"helm.toolkit.fluxcd.io","controllerKind":"HelmRelease"}
{"level":"info","ts":"2023-11-22T11:09:27.008Z","msg":"Starting workers","controller":"helmrelease","controllerGroup":"helm.toolkit.fluxcd.io","controllerKind":"HelmRelease","worker count":20}

fixes #77 #78

Copy link

github-actions bot commented Nov 22, 2023

Uffizzi Cluster pr-79 was deleted.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #79 (575c06f) into main (c2da179) will decrease coverage by 14.54%.
Report is 130 commits behind head on main.
The diff coverage is 5.05%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #79       +/-   ##
==========================================
- Coverage   19.58%   5.05%   -14.54%     
==========================================
  Files           4       8        +4     
  Lines         388    1069      +681     
==========================================
- Hits           76      54       -22     
- Misses        308    1015      +707     
+ Partials        4       0        -4     
Files Coverage Δ
controllers/uffizzicluster/workload.go 0.00% <0.00%> (ø)
controllers/uffizzicluster/deployment.go 0.00% <0.00%> (ø)
controllers/uffizzicluster/statefulset.go 0.00% <0.00%> (ø)
controllers/uffizzicluster/networkpolicy.go 0.00% <0.00%> (ø)
controllers/uffizzicluster/conditions.go 40.33% <40.33%> (ø)
controllers/uffizzicluster/helm.go 0.00% <0.00%> (ø)
...ollers/uffizzicluster/uffizzicluster_controller.go 0.00% <0.00%> (ø)
controllers/helm/build/vcluster/build.go 1.84% <1.84%> (ø)

@waveywaves waveywaves changed the title increase concurrency in the helm and ucluster controllers feat: increase concurrency in the helm and ucluster controllers Nov 22, 2023
@waveywaves waveywaves changed the title feat: increase concurrency in the helm and ucluster controllers feat: increase concurrency in controllers, make sqlite default Nov 22, 2023
@waveywaves waveywaves changed the title feat: increase concurrency in controllers, make sqlite default feat: increase concurrency in controllers, make sqlite datastore default Nov 22, 2023
@waveywaves waveywaves merged commit 5ae4f46 into main Nov 22, 2023
4 of 6 checks passed
@waveywaves waveywaves deleted the helm-controller-args branch March 12, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure dependent flux chart for more concurrency
1 participant