Changed RouteFollowed backend relation with Route #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogargon
reviewed
Dec 20, 2023
| @@ -40,7 +40,6 @@ public class RouteFollowed extends UriEntity<Long> { | |||
|
|
|||
| @JsonProperty(access = JsonProperty.Access.READ_ONLY) | |||
| @NotNull | |||
| @ManyToOne | |||
| public Route routeOrigin; | |||
| public String follows; | |||
There was a problem hiding this comment.
No need to change the type in the backend, please, keep it a Route with the updated name:
@ManyToOne
public Route follows;
In the frontend you can also store the Route entity, but when sending to the backend, if the entity already exists, use its URI instead (which is stored as a String).
There was a problem hiding this comment.
Like it is done for RouteVersion:
UdL-EPS-SoftArch/myroutes@33201e0
There was a problem hiding this comment.
All the changes are already submitted in both front and backend.
rogargon
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.