Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new class Shelter #4

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Added new class Shelter #4

merged 7 commits into from
Feb 28, 2024

Conversation

LordDangerous
Copy link
Contributor

New class Shelter

Copy link
Contributor

@jorgechp jorgechp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! just take into consideration that is better to use Long instead of String when dealing with identifiers (the user is an exception in our case)

@PauMAVA
Copy link
Contributor

PauMAVA commented Feb 27, 2024

@jorgechp Bump. I need this to implement the relations form Pet to Shelter.

@PauMAVA PauMAVA requested a review from jorgechp February 27, 2024 15:42
@elskater98
Copy link
Contributor

Hello @LordDangerous @PauMAVA, You should add more validations for mobile field.

Examples: +3466666AA66,empty string.

In this case, you should use regex. https://stackoverflow.com/questions/10631960/validate-mobile-number-using-hibernate-annotation

Copy link
Contributor

@elskater98 elskater98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@elskater98 elskater98 merged commit 0d6c55c into main Feb 28, 2024
1 check passed
@LordDangerous LordDangerous deleted the CRUD-shelter branch March 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants