Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

77 fix update room test #93

Merged
merged 13 commits into from
Nov 13, 2024
Merged

77 fix update room test #93

merged 13 commits into from
Nov 13, 2024

Conversation

samplecode17
Copy link
Contributor

No description provided.

@samplecode17 samplecode17 reopened this Nov 7, 2024
Copy link
Member

@rogargon rogargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR but it introduces some changes that need to be reverted during the next sprint. It is better to model relationships among entities using ManyToOne and references to the object for integrity purposes. It is a bad practice to store the object identifier instead

@rogargon rogargon merged commit 233e3cd into main Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants