-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular building rework #351
Conversation
as a note, if its not already done, when you pop the equipped items, you need to heal the player to full stats. |
I didn't know that. Thanks 👍 |
I just noticed, that I reformatted |
Fixes issues like not being able to pick things up and cleans up code
ad4e01a
to
a09e718
Compare
I think this is ready for review. If everything works, I'll remove all or most of the log statements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Just two questions 🙂
Uchu.World/Objects/Components/Player/ModularBuilderComponent.cs
Outdated
Show resolved
Hide resolved
I think, I will implement this as well. It fits the PR. EDIT: Btw you can just hit |
Ok never mind. Currently it's not possible to revert the state of the player once they left because the server crashes when it tries to send messages to that player. For this to work, the server would need to catch null pointer and just not send anyting |
This fixes a few issues that my old code had. It's almost a complete rewrite. Not sure if
BuildBorderComponent
is needed.TODOs:
BuildMode
enumMaybe removeBuildBorderComponent
PushEquippedItemState
andPopEquippedItemState
Exit build session if player leaves serverModularBuildingHandler
ModularBuilderComponent