Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login message for incorrect system time. #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rohbotics
Copy link
Member

The URL is made up right now, we should have a page for RTCs that is relevant to both Magni and non-Magni image users.

Fixes: #6

@rohbotics rohbotics self-assigned this Aug 2, 2020
Copy link

@mjstn mjstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting in battery is end of this page: https://learn.ubiquityrobotics.com/unboxing

@rohbotics
Copy link
Member Author

Yes the battery installation is covered there, but I thought it would be useful to have a page that would be applicable to non-Magni image users as well, because they are going to get this message almost every time they boot up, and they can't exactly install a battery on their non-existent MCB

@mjstn
Copy link

mjstn commented Aug 3, 2020

I would rather point them to a generic page somebody (must have) written about rviz and time sync. That way it decouples us from a complex support issue. We would have to suggest something like that Dallas semi plug in part and drivers and blah blah blah. I don't know how far we have to bend over backwards. Best to point them to some ROS Rviz page that already discusses the fixes. So yes, 'nice idea' but sort of above and beyond. Is there anybody complaining about that right now (to us)?

@mjstn
Copy link

mjstn commented Aug 3, 2020

If I find something it would go to this page which I created to help non-magni users. I do care Rohan, it is just a question of how valuable it would be to solve this for them if we could just point them to some external page about it. I will look for such a page and get back to you.

@rohbotics
Copy link
Member Author

I don't think we need to really talk about the rviz issue at all, all I was thinking about was a page that says that keeping time is important, and that if they are using a Magni we have solved this problem they need to install a battery (insert link here). If they are not using Magni, they can get one of these RTC modules (list of links) and configure it by doing XYZ simple step.

If we add this warning and don't point to something relevant for both Magni and non-Magni users, I will probably get at least 4 emails a week asking about it, so I would rather come out ahead and provide a link. A vast majority of our image users don't have a Magni, so I want to make sure that we have something reasonable there.

Copy link
Contributor

@MoffKalast MoffKalast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit late to the party here, but yeah seems like a good addition. It's certainly better than nothing and should help some people notice the issue.

@rohbotics
Copy link
Member Author

@mjstn @MoffKalast Updated the URL so now it actually works. Let me know if this is still good to merge.

@MoffKalast
Copy link
Contributor

We should probably integrate this into pi_image2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MOTD message for bad time
3 participants