Make //lua work with expressions as well #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Mar 26, 2024
sfan5
changed the title
imre84
added a commit
to imre84/Minetest-WorldEdit
that referenced
this pull request
Mar 28, 2024
imre84
added a commit
to imre84/Minetest-WorldEdit
that referenced
this pull request
Mar 28, 2024
|
hello, ok so do I need to do anything more to make this PR accepted/merged? |
|
I'm quite short on time, so you just have to wait. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
so with this patch you can do something like
//lua return minetest.get_node_light(p.pos)I think this is a useful development helper tool for mod developers, maybe it can save you 1-2 server restarts. Also it is backwards compatible: every//luacommand that used to work will still work