Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate worldedit_commands commands #229

Merged
merged 9 commits into from
Oct 23, 2023
Merged

Translate worldedit_commands commands #229

merged 9 commits into from
Oct 23, 2023

Conversation

alek13
Copy link
Contributor

@alek13 alek13 commented Oct 6, 2023

just add translations for commands descriptions in worldedit_commands

@alek13 alek13 mentioned this pull request Oct 6, 2023
Closed
@sfan5 sfan5 self-requested a review October 8, 2023 16:25
sfan5
sfan5 reviewed Oct 12, 2023
View reviewed changes
worldedit_commands/init.lua Outdated Show resolved Hide resolved
worldedit_commands/init.lua Outdated Show resolved Hide resolved
worldedit_commands/locale/worldedit.ru.tr Outdated Show resolved Hide resolved
@alek13 alek13 requested a review from sfan5 October 16, 2023 21:28
@sfan5
Copy link
Collaborator

sfan5 commented Oct 17, 2023

Works fine but you missed a bunch:

worldedit_commands/safe.lua:	worldedit.player_notify(name, "WARNING: this operation could affect up to " .. count .. " nodes; type //y to continue or //n to cancel")
worldedit_commands/safe.lua:			worldedit.player_notify(name, "no operation pending")
worldedit_commands/safe.lua:			worldedit.player_notify(name, "no operation pending")
worldedit_commands/init.lua:		worldedit.player_notify(name, "Schematic was created with a newer version of WorldEdit.")
worldedit_commands/init.lua:		worldedit.player_notify(name, "region reset")
worldedit_commands/init.lua:		worldedit.player_notify(name, "region marked")
worldedit_commands/init.lua:		worldedit.player_notify(name, "region unmarked")
worldedit_commands/init.lua:		worldedit.player_notify(name, "current region has a volume of " .. volume .. " nodes ("
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes replaced")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes replaced")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes copied")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes moved")
worldedit_commands/init.lua:			worldedit.player_notify(name, count .. " nodes stacked")
worldedit_commands/init.lua:			worldedit.player_notify(name, count .. " nodes stacked")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes stretched")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes transposed")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes flipped")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes rotated")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes oriented")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes updated")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes updated")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes removed")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes hidden")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes suppressed")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes highlighted")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes restored")
worldedit_commands/init.lua:			worldedit.player_notify(name, "Could not save file to \"" .. filename .. "\"")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes saved")
worldedit_commands/init.lua:			worldedit.player_notify(name, "Schematic empty, nothing allocated")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes allocated")
worldedit_commands/init.lua:			worldedit.player_notify(name, "Loading failed!")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " nodes loaded")
worldedit_commands/init.lua:			worldedit.player_notify(name, "code error: " .. err)
worldedit_commands/init.lua:			worldedit.player_notify(name, "code successfully executed", false)
worldedit_commands/init.lua:			worldedit.player_notify(name, "code error: " .. err, false)
worldedit_commands/init.lua:			worldedit.player_notify(name, "code successfully executed", false)
worldedit_commands/init.lua:			worldedit.player_notify(name, "Failed to create Minetest schematic")
worldedit_commands/init.lua:			worldedit.player_notify(name, "Saved Minetest schematic to " .. param)
worldedit_commands/init.lua:			worldedit.player_notify(name, "failed to place Minetest schematic")
worldedit_commands/init.lua:			worldedit.player_notify(name, "placed Minetest schematic " .. param ..
worldedit_commands/init.lua:			worldedit.player_notify(name, "select Minetest schematic probability values by punching nodes")
worldedit_commands/init.lua:			worldedit.player_notify(name, "finished Minetest schematic probability selection")
worldedit_commands/init.lua:			worldedit.player_notify(name, "currently set node probabilities:")
worldedit_commands/init.lua:			worldedit.player_notify(name, "invalid node probability given, not saved")
worldedit_commands/init.lua:		worldedit.player_notify(name, count .. " objects cleared")
worldedit_commands/cuboid.lua:			worldedit.player_notify(name, "Missing privileges: " ..

@alek13
Copy link
Contributor Author

alek13 commented Oct 18, 2023

@sfan5 , I add missed translations. Also I found and add another bunch of missed in init.lua.
Also translate safe.lua & cuboid.lua.

But I left it as it is a couple of phrases in commands with lua-code execution, like:

worldedit.player_notify(name, "code error: " .. err)
worldedit.player_notify(name, "code successfully executed", false)
worldedit.player_notify(name, "code error: " .. err, false)

Because people who executes lua-code should know english, and anyway the err will be in english anyway

@sfan5
Copy link
Collaborator

sfan5 commented Oct 18, 2023

Sure, that's ok.

@alek13
Add wand.lua translarion. Some fixes for translations:
62bb1cc 
- add missed `count` var
- fix terminology "blocks" -> "nodes" for `//outset` `//inset`
- change textdomain `worldedit` -> `worldedit_commands`
- add missed translation ("invalid usage") in `//cubeapply`
@alek13 alek13 requested a review from sfan5 October 19, 2023 14:22
@sfan5 sfan5 merged commit ccfb6b4 into Uberi:master Oct 23, 2023
2 checks passed
@sfan5
Copy link
Collaborator

sfan5 commented Oct 23, 2023

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alek13 @sfan5