Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jf99 fix camera2DistortionCoef() #787

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jf99
Copy link

@jf99 jf99 commented Jul 26, 2023

camera2DistortionCoef() was referencing vPinHoleDistorsion1_.data() which can lead to out-of-bounds reading and incorrect image processing.

@jf99 jf99 marked this pull request as draft July 26, 2023 12:48
@jf99
Copy link
Author

jf99 commented Jul 26, 2023

Now I also initialized the member variables of Settings. Not doing so made valgrind complain about decision making based on uninitialized data (e.g. if IMU config is missing in the calibration.yml).

I tried to choose reasonable default values, but I don't feel confident for all of them. However, any defined value is better than an undefined value.

@jf99 jf99 marked this pull request as ready for review July 26, 2023 13:31
@jeremysalwen
Copy link

Disclaimer: I don't intend to create spam. If the ORB_SLAM3 developers wish me to stop posting, I will cease immediately.

ORB_SLAM3 seems to be inactive, but there are a number of community patches, including yours, which provide important bugfixes or improvements. Therefore I have created a new project ORB_SLAM_COMMUNITY (https://github.com/jeremysalwen/ORB_SLAM_COMMUNITY) to gather together these improvements and continue active development. I have already merged this PR in the ORB_SLAM_COMMUNITY version. We would welcome any other contributions you might have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants