HW [-1] Mailroom_OO #223
Open
HW [-1] Mailroom_OO #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Cornutt <[email protected]>
|
@dancornutt - this PR has conflicts - see if you can resolve them by using the "Resolve conflicts" button and editing the files directly in Git Hub. Reach out if you have questions. |
charlesrobison
added
the
Credit Given
|
Sorry I about that, sometimes I don't know what causes the merge conflicts. I used the online gui and it seemed to work. |
|
Great! |
|
Lots of versions here -- not sure which to review! We've given you full credit. And the yaml is pretty slick -- nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got mailroom_oo working. Reads yaml file for db input, uses dictionary with name as key and donor as value. There is always more to improve on but this is a good breaking point. Perhaps I'll work on it over break to improve the user experience and reporting.